Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mich elle luna patch 2 #627

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

Mich elle luna patch 2 #627

wants to merge 42 commits into from

Conversation

mich-elle-luna
Copy link
Collaborator

@mich-elle-luna mich-elle-luna commented Aug 30, 2024

@mich-elle-luna mich-elle-luna requested a review from a team September 11, 2024 16:00
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mich-elle-luna Basically looks OK, but the Learn menu seems to pop up over the menu bar (Products doesn't and none of the menus in the existing layout do that either).

@mich-elle-luna
Copy link
Collaborator Author

@mich-elle-luna Basically looks OK, but the Learn menu seems to pop up over the menu bar (Products doesn't and none of the menus in the existing layout do that either).

Thanks Andy! Good catch, I had it working, must have changed something when I was fiddling with the mobile view. Will fiddle some more on this one.

Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it on a few pages and it seems to be OK everywhere now. J'approve!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants