Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC: RDI in the cloud #570

Draft
wants to merge 56 commits into
base: main
Choose a base branch
from
Draft

RC: RDI in the cloud #570

wants to merge 56 commits into from

Conversation

kaitlynmichael
Copy link
Contributor

@kaitlynmichael kaitlynmichael self-assigned this Aug 19, 2024
Copy link
Contributor

github-actions bot commented Aug 19, 2024

Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of possible suggestions, but there are also some gltiches that need attention. Otherwise, looking great so far :-)

content/operate/rc/databases/rdi/_index.md Outdated Show resolved Hide resolved
content/operate/rc/databases/rdi/_index.md Outdated Show resolved Hide resolved
content/operate/rc/databases/rdi/_index.md Outdated Show resolved Hide resolved

Only the following are supported at this time:

- One source database connected to one target database
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go with these limitations in this order:

  • Redis Cloud Pro tier
  • Ingest use case
  • AWS platform (source and target database)
  • One source database connected to one target database

@cmilesb cmilesb self-assigned this Aug 29, 2024
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things (broken link does need fixing, though) but otherwise looking really good :-)

content/operate/rc/databases/rdi/define.md Outdated Show resolved Hide resolved
Comment on lines +25 to +29
Select **Add schema** to add additional database schemas.

Select **Delete** to delete a schema. You must have at least one schema to continue.

After you've selected the schemas and tables you want to sync, select **Continue**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended to be a sublist (bulletted)? I definitely think it should be because the formatting currently looks a bit odd without it.

Suggested change
Select **Add schema** to add additional database schemas.
Select **Delete** to delete a schema. You must have at least one schema to continue.
After you've selected the schemas and tables you want to sync, select **Continue**.
- Select **Add schema** to add additional database schemas.
- Select **Delete** to delete a schema. You must have at least one schema to continue.
- After you've selected the schemas and tables you want to sync, select **Continue**.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will be a lot easier to parse once I add screenshots.

content/operate/rc/databases/rdi/provision.md Outdated Show resolved Hide resolved

## Pipeline provisioning errors {#errors}

Add errors here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you haven't been provided with the list of errors yet :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, yes. I need to go through the mockups again.


1. In the [Redis Cloud console](https://cloud.redis.io/), go to your target database and select the **Data Pipeline** tab.
1. Select **Create data pipeline**.
1. Select your source database type. The following database types are supported:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also mention MariaDB and Aurora in the intro page. AFAIK, MariaDB is basically the same as MySQL, so I generally write MySQL/MariaDB together. Is Aurora specific to cloud RDI, with it being an Amazon product? Also, if we do support Aurora for this then do we need some extra instructions for it in the Prepare Source Databases section?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaronp68 - Can you elaborate more on the Aurora inclusion? Is it the same as mySQL/mariaDB, or do we need to add more information as Andy said?

Comment on lines +31 to +35
Select **Add schema** to add additional database schema.

Select **Delete** to delete a schema. You must have at least one schema to continue.

After you've selected the schemas and tables you want to sync, select **Continue**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sublist again, maybe?

Suggested change
Select **Add schema** to add additional database schema.
Select **Delete** to delete a schema. You must have at least one schema to continue.
After you've selected the schemas and tables you want to sync, select **Continue**.
- Select **Add schema** to add additional database schema.
- Select **Delete** to delete a schema. You must have at least one schema to continue.
- After you've selected the schemas and tables you want to sync, select **Continue**.

andy-stark-redis and others added 19 commits October 22, 2024 10:28
DOC-4386 Create github workflow for fetching command json files from module repositories
Add missing checkout action in redis_modules_docs_sync workflow
Add pull request permissions to redis_modules_docs_sync workflow
pull-request creation logic should only run when there is a module ch…
Co-authored-by: andy-stark-redis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet rc Redis Cloud docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants