Skip to content

Commit

Permalink
feat: added de-register command (#1812)
Browse files Browse the repository at this point in the history
* Enterprise crete kafka interactive (#1819)

* refactor: moving list enterprise clusters to util package

* feat: start of interactive enterprise create

* refactor: refactor of create kafka ams checks for enterprise quota (#1822)

* feat: when using dedicated with kafka create, we now check the capacity
of the cluster

* refactor: refactor of the interactive create kafka cmd

* refactor: refactoring dedicated list to use refactored search string func

* refactor: refactor and addition of name + id of cluster in prompt

* refactor: refactor to functional create enterprise flow with some updates based on reviews

* Add machine pool logic (#1795)

* feat: addition of the new dedicated command to select ocm cluster

* feat: addition of getting machine pools and hitting the register cluster endpoint in KFM

* refactor: addition of close ocm connection

* fix: addition of autoscaling check logic

* refactor: addresses commments made in PR

* refactor: addresses comments in review

* feat: addition of the addon installation flow

* feat: addition of cluster-id flag

* refactor: addresses some further comments in the review

* feat: addition of localization

* refactor: addition of error when user has no valid clusters

* chore(vendor): update vendoring (#1798)

* Add cluster id to create kafka (#1804)

* feat: addition of descriptions and examples to dedicated

* feat: Allows the CLI to install stage env addons when terraforming customer-cloud dataplane clusters

* refactor: the default api url is now set when creating a connection instead of in the registercluster cmd file

* refactor: update some func and var names

* refactor: add cluster-id flag to create kafka cmd to allow kafka creation on CC cluster

* refactor: doc and small refactor

* refactor: Refactor ocm methods out of register cmd file (#1807)

* feat: addition of descriptions and examples to dedicated

* feat: Allows the CLI to install stage env addons when terraforming customer-cloud dataplane clusters

* refactor: extraction of clustermgmt funcs from register to own dir

* refactor: addresses cluster pagination and refactor of ocm functions

* feat: added deregister command

* refactor: imrpoved quality of deregister command

* chore: added localisation to deregister command

* feat: deregister now waits for all kafkas to be deleted

* fix: better logging when deleting kafka

* refactor: getting cluster list now ask kfm then ocm

* chore: remove unused fields

* fix: edge case handling in deregister

* docs: update the docs (#1826)

* refactor: print the httpresponse (#1827)

* fix: fixing broken lints

* chore: rebase changes

---------

Co-authored-by: Dimitri Saridakis <[email protected]>
Co-authored-by: Ramakrishna Pattnaik <[email protected]>
  • Loading branch information
3 people authored Mar 8, 2023
1 parent de7a5c6 commit 24ee8a6
Show file tree
Hide file tree
Showing 14 changed files with 468 additions and 44 deletions.
2 changes: 1 addition & 1 deletion docs/commands/rhoas.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions docs/commands/rhoas_dedicated.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 44 additions & 0 deletions docs/commands/rhoas_dedicated_deregister-cluster.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/commands/rhoas_dedicated_list.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions docs/commands/rhoas_dedicated_register-cluster.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pkg/cmd/dedicated/dedicated.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package dedicated

import (
"github.com/redhat-developer/app-services-cli/pkg/cmd/dedicated/deregister"
"github.com/redhat-developer/app-services-cli/pkg/cmd/dedicated/listclusters"
"github.com/redhat-developer/app-services-cli/pkg/cmd/dedicated/register"
"github.com/redhat-developer/app-services-cli/pkg/shared/factory"
Expand All @@ -18,6 +19,7 @@ func NewDedicatedCmd(f *factory.Factory) *cobra.Command {
cmd.AddCommand(
register.NewRegisterClusterCommand(f),
listclusters.NewListClusterCommand(f),
deregister.NewDeRegisterClusterCommand(f),
)

return cmd
Expand Down
Loading

0 comments on commit 24ee8a6

Please sign in to comment.