Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting Argo CD sync parameters for cnv/image-builder apps. #140

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Adjusting Argo CD sync parameters for cnv/image-builder apps. #140

merged 1 commit into from
Sep 20, 2021

Conversation

nasx
Copy link
Collaborator

@nasx nasx commented Sep 14, 2021

Addresses 1 and 2 in issue #126.

@nasx nasx requested a review from sabre1041 September 14, 2021 16:15
@pkliczewski
Copy link

This fix seems to be step in the right direction. I see that cnv was correctly deployed and image-builder vm was created correctly. Unfortunately there are still other issues preventing the vm to boot. I tried it several times on different machines and different clusters and at each time the cluster end up being in slightly different state. Sometimes I see quay or nexus issues. I noticed openshift-gitops-application-controller-0 crashes as well. I think we need to update #126 or create new issue to track those issues.

@pkliczewski pkliczewski mentioned this pull request Sep 20, 2021
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sabre1041 sabre1041 merged commit b12cc85 into redhat-cop:main Sep 20, 2021
@nasx nasx deleted the sync-issues branch September 23, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants