Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Configuration of Logging Format in Helm Chart Deployment #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iflan7744
Copy link

This PR introduces an update to the Helm chart, enabling the selection of the logging format as either "development" or "production."

More info about log options,
https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/log/zap#Options.BindFlags

opts := zap.Options{Development: true,}
opts.BindFlags(flag.CommandLine)
flag.Parse()

By default, the helm chart deployment will use the development mode settings because the above code block, allowing logs to be in plain format.

However, with my changes to the helm chart, the user has the ability to tailor the log output to match their specific needs. Whether they prefer a JSON format for easier log parsing and analysis or a plain format for more straightforward readability, the helm chart now accommodates both options.

@iflan7744
Copy link
Author

@raffaelespazzoli can you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant