feat: IBM Security Verify provider #328
Conversation
boonware
commented
Nov 15, 2024
boonware
commented
- Add support for IBM Security Verify as a group provider.
- There are further improvements that could be made later, but for now this provides a fully functioning synchronization between ISV and OpenShift.
- Some unit tests added for the ISV API client.
There was a problem hiding this comment.
Thanks for the contribution!
A few changes requested which were causing errors
In addition, can this section also be updated to match the new README content?
|
@sabre1041 Build is failing when download the vulnerability DB due to "too many requests", can we try again? |
We are getting hit by the discussions in this thread We will monitor when a new version is available. but in the meantime, will hit retry until it passes |
|
@sabre1041 I have created another PR to help address the "too many requests" problem: #329 |
.github/workflows/pr.yml
Outdated
| @@ -9,7 +9,7 @@ jobs: | |||
| name: shared-operator-workflow | |||
| uses: redhat-cop/github-workflows-operators/.github/workflows/[email protected] | |||
| with: | |||
| GO_VERSION: ~1.21 | |||
| GO_VERSION: ~1.23 | |||
There was a problem hiding this comment.
The current version of controller-runtime is not compatible with golang 1.23. Would recommend omitting the change of go version from this PR so that it can be handled separately as part of a larger set of dependency updates
There was a problem hiding this comment.
@sabre1041 I have restored the version to 1.21. I noticed that there was a mismatch between the version declared in the workflow and go.mod, and with the version of the base image. I have kept the change in the base image to match 1.21. Please let me know if this also needs to go back to 1.18 for some reason.
|
@boonware Thanks again for the contribution and apologies for the few road bumps in the process |
