Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch to staging cluster-provisioner pod read #4903

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ascerra
Copy link

@ascerra ascerra commented Nov 13, 2024

This PR should patch the clusterRole cluster-provisioner to also allow for getting pod logs.

Copy link

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ascerra
Once this PR has been reviewed and has the lgtm label, please assign ifireball for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -0,0 +1,8 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patching the resource like this will replace it entirely. Use kustomize build components/cluster-as-a-service/staging to verify the resulting ClusterRole contains the rules from the base rbac plus your changes.

Take a look at this patch for an example of how to append to an array: https://github.com/redhat-appstudio/infra-deployments/blob/b22e629801630a927a1b0f5aed8d6dfea8319c9c/components/cluster-as-a-service/staging/add-hypershift-params.yaml

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright based on the newest changes I'm adding new resources instead of editing existing ones so I shouldn't be replacing anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants