chore: update application-api version #489
Conversation
14rcole
force-pushed
the
update-application-api
branch
from
13557c7
to
eff9b24
Compare
|
|
|
/retest |
14rcole
force-pushed
the
update-application-api
branch
13 times, most recently
from
b7b043e
to
fed7cf8
Compare
The component status CRD had a new field to it, but application-service would overwrite the field when anyone attempted to update it. Updating application-service to the newest version of application-api fixes this issue Signed-off-by: Ryan Cole <[email protected]>
14rcole
force-pushed
the
update-application-api
branch
from
fed7cf8
to
d232108
Compare
|
|
/test application-service-e2e |
|
@14rcole: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 14rcole, jencull The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
The component status CRD had a new field to it, but application-service would overwrite the field when anyone attempted to update it. Updating application-service to the newest version of application-api fixes this issue
Which issue(s)/story(ies) does this PR fixes:
There isn't a story for this, but it unblocks an issue that will allow us to implement STONEINTG-1008
PR acceptance criteria:
Unit/Functional tests
Documentation
Client Impact
How to test changes / Special notes to the reviewer:
Deploy the change to a cluster. Create a component on the cluster and patch it with
kubectl patch component --type json ${COMPONENT_NAME} -p '{"status": {"lastPromotedImage": "quay.io/test/sample-image:latest"}}' --type merge --subresource status --dry-run=server -o yaml. Without this change the yaml output will not show.status.lastPromotedImage. With this change it will.