Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] release-2024a from opendatahub-io:2024a #459

Closed
wants to merge 26 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 3, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Copy link

openshift-ci bot commented Dec 3, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a red-hat-data-services member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

github-actions bot and others added 2 commits December 9, 2024 22:31
…#815)

* Update piplock renewal gh action

Remove old obsolete files

Include codeserver notebook on the refresh-piplock-files recipe

Update refresh-pipfilelock-files to accept optional file directories for updates

Update documentation in regards the Pipfile lock generation

(cherry picked from commit ca80fee)

* fixup proper 2024a paths and python versions

* fixup put intel images into their proper place

* fixup also remove the 3.11 option

---------

Co-authored-by: atheo89 <[email protected]>
Copy link

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign paulovmr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jiridanek and others added 19 commits December 19, 2024 11:46
… project skeleton (#755)

* NO-ISSUE: feat(codeserver/e2e): add initial playwright project skeleton

* NO-ISSUE: feat(codeserver/e2e): add a basic README.md

* NO-ISSUE: add testcontainers as a dependency

* NO-ISSUE: new customizable and flexible config

* check env variables to determine how to run
* take screenshots on failure
* don't open annoying html report
* disable parallel runs

* exclude pnpm-lock.yaml from yamllint

* move Playwright tests from codeserver/e2e to tests/browser

* create a new containers folder for (future) testing of containers in Python

(cherry picked from commit 768ae5c)
… code-server (#774)

* RHOAIENG-15152: feat(codeserver/e2e): add playwright test for starting code-server

* DO-NOT-COMMIT: trigger GHA

* fixup typo in utils.ts

* fixup default to not using existing CDP browser instance

* fixup remove commented code about using dotenv

* fixup print more meaningful exception when misconfigured

* fixup forgot to change paths in gha

* suppress the npm funding message

* Revert "DO-NOT-COMMIT: trigger GHA"

This reverts commit 629e732.

(cherry picked from commit cd16a28)
…ent failures to download later (#777)

* RHOAIENG-16076: tests(gha): pre-pull trivy vulnerabilities db to prevent failures to download later

* fix from review; use the only true condition to check if trivy should run

(cherry picked from commit 6477ed4)
…gs (#781)

I did not actually benchmark this, and the speed of the disk does not matter much, but since I found a guide and the suggested options look reasonable, then, why not?

(cherry picked from commit c8e181a)
…age name in all branches

(cherry picked from commit 7265949)
…ot run out of disk space

When I was testing this in the all-in-one PR, I had 4096 MB reserved on /.
I did not realize that trivy relied on that disk space.

```
build (codeserver-ubi9-python-3.11) / build
System.IO.IOException: No space left on device : '/home/runner/runners/2.320.0/_diag/Worker_20241125-163906-utc.log'
Unhandled exception. System.IO.IOException: No space left on device : '/home/runner/runners/2.320.0/_diag/Worker_20241125-163906-utc.log'
   at System.IO.RandomAccess.WriteAtOffset(SafeFileHandle handle, ReadOnlySpan`1 buffer, Int64 fileOffset)
   at System.IO.Strategies.BufferedFileStreamStrategy.FlushWrite()
   at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
   at System.Diagnostics.TextWriterTraceListener.Flush()
   at GitHub.Runner.Common.HostTraceListener.WriteHeader(String source, TraceEventType eventType, Int32 id)
   at GitHub.Runner.Common.HostTraceListener.TraceEvent(TraceEventCache eventCache, String source, TraceEventType eventType, Int32 id, String message)
   at System.Diagnostics.TraceSource.TraceEvent(TraceEventType eventType, Int32 id, String message)
   at GitHub.Runner.Worker.Worker.RunAsync(String pipeIn, String pipeOut)
   at GitHub.Runner.Worker.Program.MainAsync(IHostContext context, String[] args)
System.IO.IOException: No space left on device : '/home/runner/runners/2.320.0/_diag/Worker_20241125-163906-utc.log'
   at System.IO.RandomAccess.WriteAtOffset(SafeFileHandle handle, ReadOnlySpan`1 buffer, Int64 fileOffset)
   at System.IO.Strategies.BufferedFileStreamStrategy.FlushWrite()
   at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
   at System.Diagnostics.TextWriterTraceListener.Flush()
   at GitHub.Runner.Common.HostTraceListener.WriteHeader(String source, TraceEventType eventType, Int32 id)
   at GitHub.Runner.Common.HostTraceListener.TraceEvent(TraceEventCache eventCache, String source, TraceEventType eventType, Int32 id, String message)
   at System.Diagnostics.TraceSource.TraceEvent(TraceEventType eventType, Int32 id, String message)
   at GitHub.Runner.Common.Tracing.Error(Exception exception)
   at GitHub.Runner.Worker.Program.MainAsync(IHostContext context, String[] args)
   at System.IO.RandomAccess.WriteAtOffset(SafeFileHandle handle, ReadOnlySpan`1 buffer, Int64 fileOffset)
   at System.IO.Strategies.BufferedFileStreamStrategy.FlushWrite()
   at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
   at System.Diagnostics.TextWriterTraceListener.Flush()
   at System.Diagnostics.TraceSource.Flush()
   at GitHub.Runner.Common.TraceManager.Dispose(Boolean disposing)
   at GitHub.Runner.Common.TraceManager.Dispose()
   at GitHub.Runner.Common.HostContext.Dispose(Boolean disposing)
   at GitHub.Runner.Common.HostContext.Dispose()
   at GitHub.Runner.Worker.Program.Main(String[] args)
```

(cherry picked from commit 56a49e2)
…avis-hansson.com/p/make/ (#778)

This way the Makefile will run even when /bin/sh is not Bash, and there are event more smaller benefits.

(cherry picked from commit 4a1646b)
…e can share containers/storage with cri-o later (#782)

(cherry picked from commit 7650cd8)
…ning Makefile tests (#783)

* RHOAIENG-16076: tests(gha): install a cri-o backed kubernetes for running tests

* Update .github/workflows/build-notebooks-TEMPLATE.yaml

Co-authored-by: Jan Stourac <[email protected]>

---------

Co-authored-by: Jan Stourac <[email protected]>
(cherry picked from commit 117a479)
…books Github Actions (#775)

* RHOAIENG-16076: tests(gha): run Makefile tests in GitHub Actions

* fixup, looks like I lost the second changed line from #761 (comment) when merging the work

* fixup, linter wants space in the comments; IntelliJ is ok with it, so let's do that

* fixup, add reference to OpenShift CI for the source of the make invocations

* fixup, the ifNotPresent pull policy (for PR checks without image registry) and the symbolic links apparently needed to deploy rocm stuff

(cherry picked from commit b3d8af0)
…o 2024a branch and tests fetch the right test data
[2024a] NO-JIRA: bring in CI fixes from the `main` branch into the `2024a` branch
[2024a] Update pipfile renewal for 2024a branch
openshift-merge-bot bot and others added 4 commits December 19, 2024 14:36
…16-to-2024a

[2024a] NO-JIRA: chore(gha): run code-server playwright tests for pushes (and scheduled run) as well
…19-to-2024a

[2024a] NO-JIRA: chore(tests): use gmake on macOS
…ools to 70.0.0 for CVE fixes (#824)

* update setuptools to 70.0.0 for CVE fixes

* Update Pipfile.lock files by piplock-renewal.yaml action

* Update Pipfile.lock files by piplock-renewal.yaml action

---------

Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
@atheo89
Copy link
Member

atheo89 commented Jan 15, 2025

replaced by: #479

@atheo89 atheo89 closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants