Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AnnotationsToAttributes] Add @requires translation to attributes (#441) #442

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewnicols
Copy link
Contributor

No description provided.

@andrewnicols andrewnicols force-pushed the RequiresAnnotationToAttribute branch from 9453554 to a15d46d Compare January 16, 2025 08:00
@andrewnicols andrewnicols force-pushed the RequiresAnnotationToAttribute branch from a15d46d to 8986bbe Compare January 20, 2025 07:28
@andrewnicols
Copy link
Contributor Author

Thanks @samsonasik,

I've made the change to add $hasChanged and rebased.

@samsonasik
Copy link
Member

You can run:

vendor/bin/rector && composer fix-cs

to fix CI

@andrewnicols andrewnicols force-pushed the RequiresAnnotationToAttribute branch from 8986bbe to a70b5e6 Compare January 20, 2025 23:50
@samsonasik
Copy link
Member

samsonasik commented Jan 21, 2025

@andrewnicols
Copy link
Contributor Author

I think this can be registered to config set https://github.com/rectorphp/rector-phpunit/blob/main/config/sets/annotations-to-attributes.php

Agreed - I've added it to the set, and I've copied the test into the set Fixtures folder too.

@andrewnicols andrewnicols force-pushed the RequiresAnnotationToAttribute branch from a70b5e6 to a6d7151 Compare January 21, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants