Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scrapping.py #181

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Update scrapping.py #181

merged 1 commit into from
Jun 8, 2024

Conversation

Harshitmishra001
Copy link
Contributor

Related Issue

Updating amazon_scrapping /scrapping.py for imporvements
Issue #180

Description

Key Improvements:

  1. Ensures elements are loaded before interacting with them.
  2. Correctly handles the pagination and breaks the loop when there are no more pages.
  3. Uses the correct XPATH and class names.
  4. Creates a DataFrame with a column name and saves it correctly.

Type of PR

  • Bug fix
  • [✅ ] Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Screenshot 2024-06-08 113151
Screenshot 2024-06-08 113201

Checklist:

  • [ ✅] I have performed a self-review of my code
  • [ ✅] I have read and followed the Contribution Guidelines.
  • [ ✅] I have tested the changes thoroughly before submitting this pull request.
  • [ ✅] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [ ✅] I have commented my code, particularly in hard-to-understand areas.

@sanjay-kv
Copy link
Member

i need to run and test, give me a day of time. or today eve

@Harshitmishra001
Copy link
Contributor Author

No problem ,
when I was done writing the code I actually forgot to create a issue for it earlier that's why my PR was early😅

@sanjay-kv sanjay-kv merged commit 18f26c5 into recodehive:main Jun 8, 2024
2 checks passed
@sanjay-kv
Copy link
Member

image

could you help fixing this.

@Harshitmishra001
Copy link
Contributor Author

Harshitmishra001 commented Jun 8, 2024

Hi I'm sure I can try to 😄 I will look into it after 10pm as currently I am out of station 😅

@sanjay-kv
Copy link
Member

@Harshitmishra001 i need one help with simillar repo. would you like to connect on gmeet for the same.

@Harshitmishra001
Copy link
Contributor Author

@sanjay-kv Sure we can do it tomorrow whenever you are available😄

@sanjay-kv
Copy link
Member

sanjay-kv commented Jun 11, 2024

okay. could you please send me a linkedin request. will take it from there or give me your email ID

@Harshitmishra001
Copy link
Contributor Author

Harshitmishra001 commented Jun 11, 2024

@sanjay-kv Hi, We are already connected on Linkedin
My linkedin ID - https://www.linkedin.com/in/harshit-mishra-98329128a/
email id - [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants