Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reana-dev): change run-example to use gherkin-parser module (#817) #817

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

ajclyall
Copy link
Contributor

@ajclyall ajclyall commented Aug 5, 2024

Run-example now uses the test files in the specification file to check the correctness of the results (by running the test command).

@ajclyall ajclyall self-assigned this Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.80%. Comparing base (cd94d12) to head (add18d5).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
reana/reana_dev/run.py 75.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #817       +/-   ##
===========================================
+ Coverage   19.22%   29.80%   +10.57%     
===========================================
  Files          26       26               
  Lines        2512     2483       -29     
===========================================
+ Hits          483      740      +257     
+ Misses       2029     1743      -286     
Files with missing lines Coverage Δ
reana/reana_dev/run.py 54.14% <75.00%> (+27.22%) ⬆️

... and 9 files with indirect coverage changes

ajclyall added a commit to ajclyall/reana that referenced this pull request Aug 6, 2024
Add tests for gherkin-parser implementation of run-example.
@ajclyall ajclyall marked this pull request as ready for review August 6, 2024 10:13
@mdonadoni
Copy link
Member

PS: this PR needs to be rebased

ajclyall added a commit to ajclyall/reana that referenced this pull request Aug 22, 2024
If a workflow throws an error while being tested (in run-example), it is now classified as failing
ajclyall added a commit to ajclyall/reana that referenced this pull request Aug 22, 2024
…nahub#817)

Run-example now uses uses the test files in the specification file
to check the correctness of the results (by running the test command).
ajclyall added a commit to ajclyall/reana that referenced this pull request Aug 22, 2024
Add tests for gherkin-parser implementation of run-example.
ajclyall added a commit to ajclyall/reana that referenced this pull request Aug 22, 2024
If a workflow throws an error while being tested (in run-example), it is now classified as failing
Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

PS: Please add yourself to AUTHORS.md! ;)

ajclyall added a commit to ajclyall/reana that referenced this pull request Aug 27, 2024
ajclyall added a commit to ajclyall/reana that referenced this pull request Aug 29, 2024
mdonadoni pushed a commit to ajclyall/reana that referenced this pull request Sep 18, 2024
…#817)

Run-example now uses uses the test files in the specification file
to check the correctness of the results (by running the test command).
…nahub#817)

Run-example now uses uses the test files in the specification file
to check the correctness of the results (by running the test command).
@mdonadoni mdonadoni merged commit 72bd76b into reanahub:master Sep 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants