Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(reana_dev): customize kind image version (#811) #811

Merged
merged 1 commit into from
Sep 19, 2024
Merged

feat(reana_dev): customize kind image version (#811) #811

merged 1 commit into from
Sep 19, 2024

Conversation

jlemesh
Copy link
Member

@jlemesh jlemesh commented Jul 26, 2024

Similar issue happened to me using reana-dev tool with fresh kind install. kind pulls the latest image version, but the version does not match kubeVersion in Helm chart, which causes error on Helm chart deployment.

Though Helm chart is now upgraded and accepts newest image version, at some point in time discrepancy will happen again. kindest/node image version can just be pinned (should be updated together with Helm chart) and can be allowed to customize as a CLI option.

@codecov Codecov
Copy link

codecov bot commented Jul 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@72bd76b). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
reana/reana_dev/cluster.py 33.33% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #811   +/-   ##
=========================================
  Coverage          ?   29.80%           
=========================================
  Files             ?       26           
  Lines             ?     2486           
  Branches          ?        0           
=========================================
  Hits              ?      741           
  Misses            ?     1745           
  Partials          ?        0
Files with missing lines Coverage Δ
reana/reana_dev/cluster.py 30.35% <33.33%> (ø)

jlemesh added a commit to jlemesh/reana that referenced this pull request Jul 26, 2024
@jlemesh
fix(reana_dev): pass kind_version to kind command string (reanahub#811)
c6b002f
jlemesh added a commit to jlemesh/reana that referenced this pull request Jul 26, 2024
@jlemesh
fix(reana_dev): lint cluster.py code (reanahub#811)
8900f0f
mdonadoni
mdonadoni reviewed Jul 29, 2024
View reviewed changes
reana/config.py Outdated Show resolved Hide resolved
reana/reana_dev/cluster.py Outdated Show resolved Hide resolved
reana/reana_dev/cluster.py Outdated Show resolved Hide resolved
jlemesh added a commit to jlemesh/reana that referenced this pull request Jul 30, 2024
@jlemesh
fix(reana_dev): remove default for --kind-node-version (reanahub#811)
1b3d4f8
jlemesh added a commit to jlemesh/reana that referenced this pull request Jul 30, 2024
@jlemesh
fix(reana_dev): lint cluster.py (reanahub#811)
90b3ec7
jlemesh added a commit to jlemesh/reana that referenced this pull request Jul 31, 2024
@jlemesh
feat(reana_dev): customize kind image version (reanahub#811)
7b323eb
jlemesh added a commit to jlemesh/reana that referenced this pull request Jul 31, 2024
@jlemesh
fix(reana_dev): pass kind_version to kind command string (reanahub#811)
e08b5b8
jlemesh added a commit to jlemesh/reana that referenced this pull request Jul 31, 2024
@jlemesh
fix(reana_dev): lint cluster.py code (reanahub#811)
3babe5d
jlemesh added a commit to jlemesh/reana that referenced this pull request Jul 31, 2024
@jlemesh
fix(reana_dev): remove default for --kind-node-version (reanahub#811)
335e4ab
@jlemesh jlemesh force-pushed the feat_customize_kind_image_version branch from 90b3ec7 to 85921ab Compare July 31, 2024 08:27
jlemesh added a commit to jlemesh/reana that referenced this pull request Jul 31, 2024
@jlemesh
fix(reana_dev): lint cluster.py (reanahub#811)
85921ab
@jlemesh jlemesh requested a review from mdonadoni July 31, 2024 09:11
jlemesh added a commit to jlemesh/reana that referenced this pull request Jul 31, 2024
@jlemesh
feat(reana_dev): customize kind image version (reanahub#811)
5381309
jlemesh added a commit to jlemesh/reana that referenced this pull request Jul 31, 2024
@jlemesh
fix(reana_dev): pass kind_version to kind command string (reanahub#811)
51cec3a
jlemesh added a commit to jlemesh/reana that referenced this pull request Jul 31, 2024
@jlemesh
fix(reana_dev): lint cluster.py code (reanahub#811)
d3d6752
jlemesh added a commit to jlemesh/reana that referenced this pull request Jul 31, 2024
@jlemesh
fix(reana_dev): remove default for --kind-node-version (reanahub#811)
c8ba9ff
jlemesh added a commit to jlemesh/reana that referenced this pull request Jul 31, 2024
@jlemesh
fix(reana_dev): lint cluster.py (reanahub#811)
1086dca
@jlemesh jlemesh force-pushed the feat_customize_kind_image_version branch from 85921ab to 1086dca Compare July 31, 2024 14:24
mdonadoni
mdonadoni approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, looks good! Could you squash all the commits into a single one? Then I will merge :D

jlemesh added a commit to jlemesh/reana that referenced this pull request Aug 1, 2024
@jlemesh
feat(reana_dev): customize kind image version (reanahub#811)
4a02a00
@jlemesh jlemesh force-pushed the feat_customize_kind_image_version branch from 1086dca to 4a02a00 Compare August 1, 2024 12:01
jlemesh added a commit to jlemesh/reana that referenced this pull request Aug 21, 2024
@jlemesh
feat(reana_dev): customize kind image version (reanahub#811)
8ee2bd9
@jlemesh jlemesh force-pushed the feat_customize_kind_image_version branch from 4a02a00 to 8ee2bd9 Compare August 21, 2024 14:48
jlemesh added a commit to jlemesh/reana that referenced this pull request Aug 28, 2024
@jlemesh
feat(reana_dev): customize kind image version (reanahub#811)
d21c25c
@jlemesh jlemesh force-pushed the feat_customize_kind_image_version branch from 8ee2bd9 to d21c25c Compare August 28, 2024 09:41
jlemesh added a commit to jlemesh/reana that referenced this pull request Aug 30, 2024
@jlemesh
feat(reana_dev): customize kind image version (reanahub#811)
d510990
@jlemesh jlemesh force-pushed the feat_customize_kind_image_version branch from d21c25c to d510990 Compare August 30, 2024 09:32
jlemesh added a commit to jlemesh/reana that referenced this pull request Sep 16, 2024
@jlemesh
feat(reana_dev): customize kind image version (reanahub#811)
c127b97
@jlemesh jlemesh force-pushed the feat_customize_kind_image_version branch from d510990 to c127b97 Compare September 16, 2024 12:53
jlemesh added a commit to jlemesh/reana that referenced this pull request Sep 16, 2024
@jlemesh
feat(reana_dev): customize kind image version (reanahub#811)
d330562
@jlemesh jlemesh force-pushed the feat_customize_kind_image_version branch from c127b97 to d330562 Compare September 16, 2024 12:54
@mdonadoni mdonadoni force-pushed the feat_customize_kind_image_version branch from d330562 to fedc752 Compare September 19, 2024 09:17
@mdonadoni mdonadoni merged commit fedc752 into reanahub:master Sep 19, 2024
12 checks passed
@mdonadoni
Copy link
Member

mdonadoni commented Sep 19, 2024 •
edited
Loading

Rebased and merged. I have also slighly changed the commit message: reana_dev -> reana-dev.

Nice job!

@github-actions github-actions bot mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdonadoni mdonadoni mdonadoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlemesh @mdonadoni