fix(k8s): improve error handling for Dask K8s resources #618

Alputer · 2024-11-28T09:21:39Z

Closes #617

codecov · 2024-11-28T09:24:34Z

Codecov Report

Attention: Patch coverage is 24.28571% with 53 lines in your changes missing coverage. Please review.

Project coverage is 73.71%. Comparing base (f252098) to head (a71ad83).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
reana_workflow_controller/dask.py	23.52%	52 Missing ⚠️
reana_workflow_controller/consumer.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
- Coverage   75.01%   73.71%   -1.30%     
==========================================
  Files          17       17              
  Lines        1913     1948      +35     
==========================================
+ Hits         1435     1436       +1     
- Misses        478      512      +34

Files with missing lines	Coverage Δ
reana_workflow_controller/k8s.py	`77.02% <ø> (+3.44%)`	⬆️
reana_workflow_controller/consumer.py	`55.76% <50.00%> (+1.87%)`	⬆️
reana_workflow_controller/dask.py	`59.90% <23.52%> (-16.46%)`	⬇️

Closes reanahub#617

Alputer added the workflow/dask label Nov 28, 2024

Alputer requested review from tiborsimko and mdonadoni November 28, 2024 09:21

Alputer self-assigned this Nov 28, 2024

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Nov 28, 2024

fix(k8s): handle exceptions when creating dask cluster (reanahub#618)

71cf935

Closes reanahub#617

Alputer force-pushed the dask-cluster-409 branch from b9bd76d to 71cf935 Compare November 28, 2024 13:17

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Nov 28, 2024

fix(k8s): handle exceptions when creating dask cluster (reanahub#618)

1efdce3

Closes reanahub#617

Alputer force-pushed the dask-cluster-409 branch from 71cf935 to 1efdce3 Compare November 28, 2024 13:20

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Nov 28, 2024

fix(k8s): handle exceptions when creating dask cluster (reanahub#618)

0eecea0

Closes reanahub#617

Alputer force-pushed the dask-cluster-409 branch from 1efdce3 to 0eecea0 Compare November 28, 2024 13:35

Alputer changed the title ~~fix(k8s): handle 409 conflict errors for dask resources~~ fix(k8s): handle exceptions when creating dask cluster Nov 28, 2024

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 22, 2025

fix(k8s): handle exceptions when creating dask cluster (reanahub#618)

e3a90a9

Closes reanahub#617

Alputer force-pushed the dask-cluster-409 branch 2 times, most recently from e3a90a9 to e8d797e Compare January 22, 2025 11:01

Alputer changed the title ~~fix(k8s): handle exceptions when creating dask cluster~~ fix(k8s): handle exceptions better for Dask k8s resources Jan 22, 2025

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 22, 2025

fix(k8s): handle exceptions better for Dask k8s resources (reanahub#618)

f244614

Closes reanahub#617

Alputer force-pushed the dask-cluster-409 branch from e8d797e to f244614 Compare January 22, 2025 11:01

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 22, 2025

fix(k8s): handle exceptions better for Dask k8s resources (reanahub#618)

75fed4f

Closes reanahub#617

Alputer force-pushed the dask-cluster-409 branch from f244614 to 75fed4f Compare January 22, 2025 12:17

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 22, 2025

fix(k8s): handle exceptions better for Dask k8s resources (reanahub#618)

c67b32a

Closes reanahub#617

Alputer force-pushed the dask-cluster-409 branch from 75fed4f to c67b32a Compare January 22, 2025 16:53

mdonadoni removed their request for review January 23, 2025 08:47

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 28, 2025

fix(k8s): handle exceptions better for Dask k8s resources (reanahub#618)

da5c5f2

Closes reanahub#617

Alputer force-pushed the dask-cluster-409 branch from c67b32a to da5c5f2 Compare January 28, 2025 10:27

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 28, 2025

fix(k8s): handle exceptions better for Dask K8s resources (reanahub#618)

3c92b11

Closes reanahub#617

Alputer force-pushed the dask-cluster-409 branch from da5c5f2 to 3c92b11 Compare January 28, 2025 10:39

Alputer changed the title ~~fix(k8s): handle exceptions better for Dask k8s resources~~ fix(k8s): handle exceptions better for Dask K8s resources Jan 28, 2025

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 28, 2025

fix(k8s): handle exceptions better for Dask K8s resources (reanahub#618)

dac6fb5

Closes reanahub#617

Alputer force-pushed the dask-cluster-409 branch from 3c92b11 to dac6fb5 Compare January 28, 2025 12:57

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 28, 2025

fix(k8s): handle exceptions better for Dask K8s resources (reanahub#618)

95a14d3

Closes reanahub#617

Alputer force-pushed the dask-cluster-409 branch from dac6fb5 to 95a14d3 Compare January 28, 2025 13:15

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 28, 2025

fix(k8s): handle exceptions better for Dask K8s resources (reanahub#618)

2eac122

Closes reanahub#617

Alputer force-pushed the dask-cluster-409 branch from 95a14d3 to 2eac122 Compare January 28, 2025 13:20

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 28, 2025

fix(k8s): handle exceptions better for Dask K8s resources (reanahub#618)

263db2e

Closes reanahub#617

Alputer force-pushed the dask-cluster-409 branch from 2eac122 to 263db2e Compare January 28, 2025 13:30

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 28, 2025

fix(k8s): handle exceptions better for Dask K8s resources (reanahub#618)

7ffe1c7

Closes reanahub#617

Alputer force-pushed the dask-cluster-409 branch from 263db2e to 7ffe1c7 Compare January 28, 2025 13:35

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 28, 2025

fix(k8s): handle exceptions better for Dask K8s resources (reanahub#618)

0b37c1a

Closes reanahub#617

Alputer force-pushed the dask-cluster-409 branch from 7ffe1c7 to 0b37c1a Compare January 28, 2025 14:06

fix(k8s): improve error handling for Dask K8s resources (reanahub#618)

a71ad83

Closes reanahub#617

Alputer force-pushed the dask-cluster-409 branch from 0b37c1a to a71ad83 Compare January 28, 2025 14:07

Alputer changed the title ~~fix(k8s): handle exceptions better for Dask K8s resources~~ fix(k8s): fix(k8s): improve error handling for Dask K8s resources Jan 28, 2025

Alputer changed the title ~~fix(k8s): fix(k8s): improve error handling for Dask K8s resources~~ fix(k8s): improve error handling for Dask K8s resources Jan 28, 2025

tiborsimko approved these changes Jan 28, 2025

View reviewed changes

tiborsimko merged commit a71ad83 into reanahub:master Jan 28, 2025
14 checks passed

github-actions bot mentioned this pull request Jan 28, 2025

chore(master): release 0.9.5 #578

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(k8s): improve error handling for Dask K8s resources #618

fix(k8s): improve error handling for Dask K8s resources #618

Alputer commented Nov 28, 2024

codecov bot commented Nov 28, 2024 •

edited

Loading

fix(k8s): improve error handling for Dask K8s resources #618

fix(k8s): improve error handling for Dask K8s resources #618

Conversation

Alputer commented Nov 28, 2024

codecov bot commented Nov 28, 2024 • edited Loading

Codecov Report

codecov bot commented Nov 28, 2024 •

edited

Loading