Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dask): use centralized function for Dask component names #613

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

Alputer
Copy link
Member

@Alputer Alputer commented Nov 21, 2024

This PR refactors naming of Dask components which were previously hard-coded. Now, they are set centrally in a function that is placed in reana-commons.

Closes reanahub/reana#841

@Alputer Alputer self-assigned this Nov 21, 2024
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 22, 2025
@Alputer Alputer force-pushed the dask-component-names branch from e549351 to c60af4f Compare January 22, 2025 13:16
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 22, 2025
@Alputer Alputer force-pushed the dask-component-names branch from c60af4f to a0d961b Compare January 22, 2025 13:26
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 22, 2025
@Alputer Alputer force-pushed the dask-component-names branch from a0d961b to f3f5e28 Compare January 22, 2025 14:55
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 22, 2025
@Alputer Alputer force-pushed the dask-component-names branch from f3f5e28 to 7a2f7cc Compare January 22, 2025 16:13
@Alputer Alputer changed the title refactor(dask): remove hard-coded values for dask components refactor(dask): use centralized function for Dask component names Jan 22, 2025
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 22, 2025
@Alputer Alputer force-pushed the dask-component-names branch from 7a2f7cc to 9b41f48 Compare January 22, 2025 16:53
@mdonadoni mdonadoni removed their request for review January 23, 2025 08:47
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 23, 2025
@Alputer Alputer force-pushed the dask-component-names branch from 9b41f48 to c9d2568 Compare January 23, 2025 09:00
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 23, 2025
@Alputer Alputer force-pushed the dask-component-names branch from c9d2568 to a296674 Compare January 23, 2025 09:05
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 23, 2025
@Alputer Alputer force-pushed the dask-component-names branch from a296674 to 068b1bd Compare January 23, 2025 09:12
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 23, 2025
@Alputer Alputer force-pushed the dask-component-names branch from 068b1bd to f2aaa0e Compare January 23, 2025 13:54
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 23, 2025
@Alputer Alputer force-pushed the dask-component-names branch from f2aaa0e to 29401bc Compare January 23, 2025 13:59
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 23, 2025
@Alputer Alputer force-pushed the dask-component-names branch from 29401bc to b2aa64b Compare January 23, 2025 14:05
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 23, 2025
@Alputer Alputer force-pushed the dask-component-names branch from b2aa64b to 20f3ff6 Compare January 23, 2025 14:59
@tiborsimko
Copy link
Member

todo: ‏We need to bump reana-commons for CI to pass after a new reana-commons alpha release.

Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 28, 2025
@Alputer Alputer force-pushed the dask-component-names branch from 20f3ff6 to a6bbf11 Compare January 28, 2025 09:02
Alputer added a commit to Alputer/reana-workflow-controller that referenced this pull request Jan 28, 2025
@Alputer Alputer force-pushed the dask-component-names branch from a6bbf11 to c3eaf2f Compare January 28, 2025 09:13
@tiborsimko
Copy link
Member

todo: ‏We need to bump reana-commons for CI to pass after a new reana-commons alpha release.

Also, in respect to changing the commit log message for r-commons (centralised -> central), we could adapt the release news item accordingly, to read:

refactor(dask): use central function for Dask K8s component names (#613)

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.01%. Comparing base (2797300) to head (f252098).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
reana_workflow_controller/consumer.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
+ Coverage   74.98%   75.01%   +0.02%     
==========================================
  Files          17       17              
  Lines        1911     1913       +2     
==========================================
+ Hits         1433     1435       +2     
  Misses        478      478              
Files with missing lines Coverage Δ
reana_workflow_controller/dask.py 76.36% <100.00%> (ø)
reana_workflow_controller/k8s.py 73.58% <100.00%> (+0.16%) ⬆️
reana_workflow_controller/opensearch.py 90.00% <100.00%> (+0.20%) ⬆️
reana_workflow_controller/rest/workflows.py 68.97% <100.00%> (ø)
reana_workflow_controller/workflow_run_manager.py 80.67% <100.00%> (ø)
reana_workflow_controller/consumer.py 53.89% <0.00%> (ø)

@Alputer Alputer force-pushed the dask-component-names branch from c3eaf2f to f252098 Compare January 28, 2025 09:18
@tiborsimko tiborsimko merged commit f252098 into reanahub:master Jan 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

dask: refactor hard-coded values and rename dask cluster components
2 participants