Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Django + Vue Update #508

Merged
merged 14 commits into from
Apr 11, 2024
Merged

Add Django + Vue Update #508

merged 14 commits into from
Apr 11, 2024

Conversation

acsany
Copy link
Contributor

@acsany acsany commented Mar 2, 2024

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

@acsany acsany requested a review from martin-martin March 2, 2024 13:34
martin-martin
martin-martin requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@martin-martin martin-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small quibbles: The location of your app in INSTALLED_APPS, and the name of the final step folder (that should be source_code_final/.

django-vue-graphql-update/source_code_step_3/back_end/backend/settings.py Outdated Show resolved Hide resolved
@martin-martin
Copy link
Contributor

LGTM, thanks for all your work on this @acsany 💪

@gahjelle gahjelle merged commit 52d5c5d into master Apr 11, 2024
1 check passed
@gahjelle gahjelle deleted the django-vue-graphql branch April 11, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-martin martin-martin martin-martin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acsany @martin-martin @gahjelle