Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparing unmanaged lists #6845

Merged
merged 7 commits into from
Oct 12, 2020
Merged

Fix comparing unmanaged lists #6845

merged 7 commits into from
Oct 12, 2020

Conversation

leemaguire
Copy link
Contributor

@leemaguire leemaguire commented Oct 7, 2020 •
edited
Loading

When comparing two unmanaged List<>/RLMArray objects, the backing array was not used for the comparison. Therefor doing any sort of comparison on List<> or RLMArray would always give the incorrect result.

Fixes: #5665

@leemaguire leemaguire self-assigned this Oct 7, 2020
@leemaguire leemaguire marked this pull request as ready for review October 7, 2020 15:53
tgoyne
tgoyne reviewed Oct 7, 2020
View reviewed changes
Realm/RLMArray.mm Outdated Show resolved Hide resolved
@leemaguire leemaguire requested a review from tgoyne October 7, 2020 16:35
@leemaguire leemaguire merged commit c777ff5 into master Oct 12, 2020
@leemaguire leemaguire deleted the lm/list-comparision branch October 12, 2020 08:10
tgoyne added a commit that referenced this pull request Oct 14, 2020
@tgoyne
Merge remote-tracking branch 'origin/master' into v10
26c774b 
* origin/master:
  Release 5.5.0
  Fix comparing unmanaged lists (#6845)
  Update CONTRIBUTING.md
  Save NotificationToken from Combine call (#6816)
  Upgrade to core 6.1.4
  Release 5.4.7
  Upgrade to core 6.1.3
  Actually upgrade to core 6.1.2 (#6819)
@lukaskollmer lukaskollmer mentioned this pull request Apr 27, 2021
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgoyne tgoyne tgoyne approved these changes

@jsflax jsflax Awaiting requested review from jsflax

Assignees

@leemaguire leemaguire

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Comparing two List<String> objects fails
2 participants
@leemaguire @tgoyne