[RKOTLIN-1096] Add SyncException.isFatal to signal unrecoverable sync exceptions #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rorbech
changed the title
nhachicha
approved these changes
Jul 9, 2024
...ages/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/SyncedRealmTests.kt
Outdated
Show resolved
Hide resolved
...ages/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/SyncedRealmTests.kt
Show resolved
Hide resolved
Co-authored-by: Nabil Hachicha <[email protected]>
…to cr/add-syncexception-isfatal
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sync server is deciding if an error
isFatalso we cannot separate exceptions in theSyncExceptionclass hierarchy based on this. This PR introducesSyncException.isFatalto signal unrecoverable sync errors in favor or deprecatedUnrecoverableException.It is laid out so that all existing
UnrecoverableExceptions haveisFatal=trueso should not brake existing apps.Note for reviewers: This is reworking the fix from #1767 that was not released, so semantics should be evaluated against previous released implementation and not only according to the changes of this PR.