Remove centos 7 docker image #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clementetb
added
no-changelog
no-jira-ticket
nhachicha
reviewed
Jul 4, 2024
| @@ -93,7 +92,7 @@ jobs: | |||
| retention-days: 1 | |||
|
|
|||
| build-jvm-linux-native-lib: | |||
| runs-on: ubuntu-latest | |||
| runs-on: ubuntu-22.04 | |||
There was a problem hiding this comment.
What version of libc it has? the goal with old centos:7 is to build it on the smallest libc Core supports (glibc 2.17). So maybe we can still use/install the old libc via ubuntu
rorbech
approved these changes
Jul 4, 2024
...ages/test-sync/src/commonMain/kotlin/io/realm/kotlin/test/mongodb/util/TestAppInitializer.kt
Outdated
Show resolved
Hide resolved
packages/test-sync/src/commonMain/kotlin/io/realm/kotlin/test/mongodb/util/SchemaProcessor.kt
Outdated
Show resolved
Hide resolved
packages/test-sync/src/commonMain/kotlin/io/realm/kotlin/test/mongodb/util/SchemaProcessor.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centos 7 has been deprecated as of 30th June 2024. Our CI job
build-jvm-linux-native-libused it in a docker image.This PR removes the docker image and integrates this build job in GHA using a ubuntu-22.04 image.
This is the same image as used by core: https://github.com/realm/ci/blob/master/realm/docker/build-ubuntu/Dockerfile
This PR includes the changes from #1782:
Some schema synchronization issues caused the app not being properly initialized. We have a workaround that addresses them, but unfortunately there are still some race conditions.
Tests now define the schema in the server via the admin API instead of relying on the development mode to do the synchronization. It allows to first set up the server, enable sync, and wait for sync to be enabled. Once enabled we wait to be ready to accept new clients.