[RKOTLIN-1102] Remove nullability check in SubscriptionSetImpl.waitForSynchronization
#1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rorbech
approved these changes
Jun 7, 2024
| @@ -369,7 +369,7 @@ class CredentialsTests { | |||
| payload = mapOf("mail" to TestHelper.randomEmail(), "id" to 0) | |||
| ) | |||
|
|
|||
| assertFailsWithMessage<AuthException>("unauthorized") { | |||
| assertFailsWithMessage<AuthException>("Authentication failed") { | |||
There was a problem hiding this comment.
Hmm. Weird that this has to go the other way. Was updated on the server two weeks ago and seemed pretty consistent with unauthorized throughout the server 🤔 But I guess it is ok, since it is just a test assertion 🤷
nhachicha
reviewed
Jun 7, 2024
packages/library-base/src/commonMain/kotlin/io/realm/kotlin/exceptions/RealmException.kt
Outdated
Show resolved
Hide resolved
| @@ -127,7 +127,7 @@ internal class SubscriptionSetImpl<T : BaseRealm>( | |||
| if (result) { | |||
| return true | |||
| } else { | |||
| throw BadFlexibleSyncQueryException(errorMessage!!) | |||
| throw BadFlexibleSyncQueryException(errorMessage) | |||
There was a problem hiding this comment.
is this nullable because RealmInterop.realm_sync_subscriptionset_error_str can return null/empty?
There was a problem hiding this comment.
Yes, it looks like it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1777
Removes a nullability check on the synchronization error message that is causing a null pointer exception crash