[RKOTLIN-1096] Map is_fatal to UnrecoverableSyncException
#1768
Conversation
|
|
||
| ErrorCode.RLM_ERR_SYNC_PROTOCOL_INVARIANT_FAILED, |
There was a problem hiding this comment.
Are these 3 all now under Fatal UnrecoverableSyncException?
There was a problem hiding this comment.
At least RLM_ERR_SYNC_PERMISSION_DENIED isn't, but shouldn't now any fatal (unrecoverable) errors haveis_fatal set to true?
There was a problem hiding this comment.
Checked with core, is_fatal is a better property to identify unrecoverable errors.
There was a problem hiding this comment.
Seems safest to keep this, unless you are absolutely certain that core throws the three error codes with is_fatal set. If not we will suddenly throw them as SyncExceptions instead.
| channel.send(AssertionError("Realm was successfully opened")) | ||
| } | ||
| } | ||
|
|
||
| val error = channel.receiveOrFail() | ||
| assertTrue(error is UnrecoverableSyncException, "Was $error") |
There was a problem hiding this comment.
Isn't there a test that checks UnrecoverableSyncException?
There was a problem hiding this comment.
That is the only test that mentioned UnrecoverableSyncException. I am going to add some tests using realm_sync_session_handle_error_for_testing
clementetb
force-pushed
the
ct/use_is_fatal
branch
from
24ac992
to
29c347b
Compare
clementetb
force-pushed
the
ct/use_is_fatal
branch
2 times, most recently
from
2f020e6
to
29c347b
Compare
closes #1767