-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RKOTLIN-986] K2 Support #1740
[RKOTLIN-986] K2 Support #1740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides the version bump
classpath("com.android.tools.build:gradle:4.2.2") | ||
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.0") | ||
classpath("com.android.tools.build:gradle:7.1.3") | ||
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:2.0.0-RC1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upgrade to 2.0.0
classpath("com.android.tools.build:gradle:4.2.2") | ||
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.0") | ||
classpath("com.android.tools.build:gradle:7.1.3") | ||
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:2.0.0-RC1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump to 2.0.0
@@ -34,7 +34,7 @@ buildscript { | |||
} | |||
dependencies { | |||
classpath("com.android.tools.build:gradle:7.4.0") | |||
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.0") | |||
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:2.0.0-RC1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump
@@ -34,7 +34,7 @@ buildscript { | |||
} | |||
dependencies { | |||
classpath("com.android.tools.build:gradle:8.1.0") | |||
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.10") | |||
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:2.0.0-RC1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump
@@ -34,7 +34,7 @@ buildscript { | |||
} | |||
dependencies { | |||
classpath("com.android.tools.build:gradle:8.1.0") | |||
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.10") | |||
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:2.0.0-RC1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump
This adds support for Kotlin 2.0. This branch does not have code specific to K2 compared to
main
/release
but is for compiling and testing the library with Kotlin 2, as distributables are not binary compatible across Kotlin 1.9/2.0.This is targeting
release/k2
that will be used to publish named (<x>-K2
) releases corresponding to normalreleases
when see fit.Closes #1614