Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RKOTLIN-986] K2 Support #1740

Closed
wants to merge 7 commits into from
Closed

[RKOTLIN-986] K2 Support #1740

wants to merge 7 commits into from

Conversation

rorbech
Copy link
Contributor

@rorbech rorbech commented May 7, 2024

This adds support for Kotlin 2.0. This branch does not have code specific to K2 compared to main/release but is for compiling and testing the library with Kotlin 2, as distributables are not binary compatible across Kotlin 1.9/2.0.

This is targeting release/k2 that will be used to publish named (<x>-K2) releases corresponding to normal releases when see fit.

Closes #1614

@cla-bot cla-bot bot added the cla: yes label May 7, 2024
@rorbech rorbech changed the base branch from releases to release/k2 May 7, 2024 12:17
@rorbech rorbech changed the title K2 Support [RKOTLIN-986] K2 Support May 8, 2024
@rorbech rorbech marked this pull request as ready for review May 8, 2024 12:19
Copy link
Collaborator

@nhachicha nhachicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the version bump

classpath("com.android.tools.build:gradle:4.2.2")
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.0")
classpath("com.android.tools.build:gradle:7.1.3")
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:2.0.0-RC1")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrade to 2.0.0

classpath("com.android.tools.build:gradle:4.2.2")
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.0")
classpath("com.android.tools.build:gradle:7.1.3")
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:2.0.0-RC1")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump to 2.0.0

@@ -34,7 +34,7 @@ buildscript {
}
dependencies {
classpath("com.android.tools.build:gradle:7.4.0")
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.0")
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:2.0.0-RC1")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump

@@ -34,7 +34,7 @@ buildscript {
}
dependencies {
classpath("com.android.tools.build:gradle:8.1.0")
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.10")
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:2.0.0-RC1")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump

@@ -34,7 +34,7 @@ buildscript {
}
dependencies {
classpath("com.android.tools.build:gradle:8.1.0")
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.10")
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:2.0.0-RC1")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump

@rorbech
Copy link
Contributor Author

rorbech commented May 23, 2024

This PR was targeting release/k2 as a -K2-suffix release. Superseded by #1764 that targets main for 2.0.0. The version bump comments are addressed in #1764.

@rorbech rorbech closed this May 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants