Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing initial progress notifier event #1738

Closed
wants to merge 1 commit into from
Closed

Fix missing initial progress notifier event #1738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/external/core
Open in desktop
Submodule core updated 27 files
+3 −4 CHANGELOG.md
+1 −1 Package.swift
+1 −1 dependencies.yml
+0 −1 evergreen/config.yml
+1 −3 src/external/IntelRDFPMathLib20U2/CMakeLists.txt
+0 −4 src/external/bson/CMakeLists.txt
+2 −2 src/external/bson/bson-macros.h
+1 −1 src/external/bson/bson-types.h
+1 −1 src/realm/object-store/object_store.cpp
+13 −12 src/realm/object-store/sync/impl/app_metadata.cpp
+1 −1 src/realm/object-store/sync/sync_manager.cpp
+1 −1 src/realm/object-store/sync/sync_manager.hpp
+51 −43 src/realm/object-store/sync/sync_session.cpp
+7 −7 src/realm/object-store/sync/sync_session.hpp
+1 −7 src/realm/query_engine.cpp
+18 −11 src/realm/query_engine.hpp
+7 −6 src/realm/sync/client.cpp
+1 −1 src/realm/sync/client.hpp
+0 −1 test/object-store/CMakeLists.txt
+2 −8 test/object-store/benchmarks/main.cpp
+1 −1 test/object-store/sync/client_reset.cpp
+802 −592 test/object-store/sync/session/progress_notifications.cpp
+1 −1 test/object-store/util/test_file.cpp
+2 −2 test/test_encrypted_file_mapping.cpp
+0 −21 test/test_parser.cpp
+3 −5 test/test_query2.cpp
+17 −17 test/test_sync.cpp
7 changes: 1 addition & 6 deletions ...t-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/ProgressListenerTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ import kotlinx.coroutines.withTimeout
import org.mongodb.kbson.ObjectId
import kotlin.test.AfterTest
import kotlin.test.BeforeTest
import kotlin.test.Ignore
import kotlin.test.Test
import kotlin.test.assertEquals
import kotlin.test.assertFailsWith
Expand Down Expand Up @@ -85,7 +84,6 @@ class ProgressListenerTests {
}

@Test
@Ignore // https://github.com/realm/realm-core/issues/7627
fun downloadProgressListener_changesOnly() = runBlocking {
Realm.open(createSyncConfig(app.createUserAndLogIn())).use { uploadRealm ->
// Verify that we:
Expand All @@ -103,7 +101,7 @@ class ProgressListenerTests {

// We are not sure when the realm actually knows of the remote changes and consider
// them current, so wait a bit
delay(10.seconds)
delay(5.seconds)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this enough for GHA?

realm.syncSession.progressAsFlow(Direction.DOWNLOAD, ProgressMode.CURRENT_CHANGES)
.run {
withTimeout(TIMEOUT) {
Expand Down Expand Up @@ -175,7 +173,6 @@ class ProgressListenerTests {
}

@Test
@Ignore // https://github.com/realm/realm-core/issues/7627
fun worksAfterExceptions() = runBlocking {
Realm.open(createSyncConfig(app.createUserAndLogIn())).use { realm ->
realm.writeSampleData(TEST_SIZE, timeout = TIMEOUT)
Expand All @@ -198,7 +195,6 @@ class ProgressListenerTests {
}

@Test
@Ignore // https://github.com/realm/realm-core/issues/7627
fun worksAfterCancel() = runBlocking {
Realm.open(createSyncConfig(app.createUserAndLogIn())).use { realm ->
realm.writeSampleData(TEST_SIZE, timeout = TIMEOUT)
Expand Down Expand Up @@ -229,7 +225,6 @@ class ProgressListenerTests {
}

@Test
@Ignore // https://github.com/realm/realm-core/issues/7627
fun triggerImmediatelyWhenRegistered() = runBlocking {
Realm.open(createSyncConfig(app.createUserAndLogIn())).use { realm ->
withTimeout(10.seconds) {
Expand Down
Loading