[RKOTLIN-1023] Add support for changing App Services base URL #1733
Conversation
| * @param baseUrl The new App Services base url. Use [AppConfiguration.DEFAULT_BASE_URL] to set it | ||
| * to the default value. | ||
| */ | ||
| public suspend fun updateBaseUrl(baseUrl: String) |
There was a problem hiding this comment.
Passing an empty string to updateBaseUrl would result in the base URL being set to a default value set in core.
Because the default URL is already set in core, we could replace the actual URL value in the SDK with an empty string. This way we could avoid maintaining the URL on the SDK.
AppConfiguration.DEFAULT_BASE_URL = ""
We would address this on a different PR.
There was a problem hiding this comment.
We could also make baseUrl optional and allow users to supply null here to the same effect of supplying empty string. I feel this is a bit more obvious and the C API already works that way.
CHANGELOG.md
Outdated
| @@ -7,7 +7,7 @@ This release will bump the Realm file format from version 23 to 24. Opening a fi | |||
| * None. | |||
|
|
|||
| ### Enhancements | |||
| * None. | |||
| * Add support for changing the App Services base URL. It allows to roam between Atlas and Edge Server. Changing the url would trigger a client reset. ([JIRA]https://jira.mongodb.org/browse/RKOTLIN-1023) | |||
There was a problem hiding this comment.
We should probably continue linking to the github issues.
| * @param baseUrl The new App Services base url. Use [AppConfiguration.DEFAULT_BASE_URL] to set it | ||
| * to the default value. | ||
| */ | ||
| public suspend fun updateBaseUrl(baseUrl: String) |
There was a problem hiding this comment.
We could also make baseUrl optional and allow users to supply null here to the same effect of supplying empty string. I feel this is a bit more obvious and the C API already works that way.
With this PR we add support for changing the App Services URL allowing roaming between Atlas and Edge server.
Closes #1659