Upgrade to latest core #1731
Merged
Upgrade to latest core #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clementetb
approved these changes
Apr 30, 2024
packages/cinterop/src/nativeDarwin/kotlin/io/realm/kotlin/internal/interop/ErrorCode.kt
Show resolved
Hide resolved
| @@ -1,5 +1,6 @@ | |||
| headers = realm.h realm/error_codes.h | |||
| headerFilter = realm.h realm/error_codes.h | |||
| compilerOpts = -DREALM_APP_SERVICES=1 | |||
There was a problem hiding this comment.
What does this option do?
There was a problem hiding this comment.
It's a build option to include core's default implementation of app services api. Eventually we will be able to supply our own, so that we can build the MongoDB API without core.
kneth
approved these changes
May 1, 2024
|
CI is just failing on various flaky tests due to timeouts. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Should we wait for Regression with missing download progress notification for PBS realm-core#7627 or considered it a known bugAdded it as a known bug.