Support for compiling the SDK with Kotlin 2 #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kneth
reviewed
Apr 19, 2024
| // an else clause to be exhaustive | ||
| // Family.WASM, | ||
| // Family.ZEPHYR, | ||
| else -> null |
There was a problem hiding this comment.
How do we ensure we catch new target added in the future?
There was a problem hiding this comment.
We can't both ignore non-existing symbols and ensure that we are exhaustive. This anyway a bit shady. We don't fetch minimum SDK for non-Cocoapods Kotlin Native builds. I have added a TODO about revisiting it when we skip Kotllin 1.9 support.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to binary incompatibilities of the Kotlin compile API across 1.9 and 2.0 we cannot supply a cross version compatible distribution. This PR will however update the code base so that it is possible to compile the SDK itself with both 1.9 and 2.0 to make it easier to maintain and supply a 2.0-compatible branch.
Note This PR does not enable support for K2 in consumer project nor does it change the project to use K2 itself.