Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM-568: Add a workflow that verifies PR title #1674

Closed
wants to merge 2 commits into from

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Mar 5, 2024

Adds a workflow that verifies that PR titles have the form of "R...-123".

.github/workflows/check-pr-title.yml Show resolved Hide resolved
- name: Enforce PR title
uses: realm/ci-actions/title-checker@main
with:
regex: R[A-Z]{2,5}-[0-9]{1,6}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to match RKOTLIN 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, I thought RSWIFT was the longest one 🤦‍♂️

@rorbech
Copy link
Contributor

rorbech commented Mar 7, 2024

Not for this PR, but maybe we should think of grouping all the ci-action scripts so it was obvious where there are coming from and what role they play. Ideally with a prefix that gathered them last in the list of workflows 😬

@rorbech
Copy link
Contributor

rorbech commented Mar 7, 2024

Not for this PR, but maybe we should think of grouping all the ci-action scripts so it was obvious where there are coming from and what role they play. Ideally with a prefix that gathered them last in the list of workflows 😬

If put in a separate folder it would also be easier not to trigger all the other workflows when they change.

@nirinchev
Copy link
Member Author

Sure, happy to discuss a better organization of the common workflows.

@nirinchev nirinchev closed this Mar 7, 2024
@nirinchev nirinchev deleted the ni/check-pr-title branch March 7, 2024 14:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants