Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Swig 4.2.0 #1665

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Update to Swig 4.2.0 #1665

merged 4 commits into from
Feb 23, 2024

Conversation

rorbech
Copy link
Contributor

@rorbech rorbech commented Feb 22, 2024 •
edited
Loading

@cla-bot cla-bot bot added the cla: yes label Feb 22, 2024
@rorbech rorbech changed the base branch from main to releases February 22, 2024 19:32
@rorbech rorbech changed the base branch from releases to main February 22, 2024 19:32
@rorbech rorbech marked this pull request as ready for review February 22, 2024 19:32
clementetb
clementetb approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@clementetb clementetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, shouldn't it target releases branch?

packages/jni-swig-stub/realm.i Show resolved Hide resolved
@rorbech
Copy link
Contributor Author

rorbech commented Feb 23, 2024

Looks good, shouldn't it target releases branch?

I guess we didn't GHA-enable releases yet, so think it is better to get this into main to unblock the work of releasing through GHA.

@rorbech rorbech merged commit 17e4015 into main Feb 23, 2024
12 checks passed
@rorbech rorbech deleted the cr/swig-4.2.0 branch February 23, 2024 10:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clementetb clementetb clementetb approved these changes

Assignees

@rorbech rorbech

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building from source is incompatible with SWIG 4.2.0
2 participants
@rorbech @clementetb