Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate release process to Maven Central and Gradle Plugin Portal #1663

Merged
merged 39 commits into from
Mar 8, 2024

Conversation

nhachicha
Copy link
Collaborator

@nhachicha nhachicha commented Feb 17, 2024

@nhachicha nhachicha marked this pull request as ready for review March 7, 2024 16:51
Copy link
Contributor

@rorbech rorbech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@clementetb clementetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for that gittag comment.

- name: Get Git tag
run: |
gitTag=$(git describe --tags --exact-match HEAD) || echo "NONE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tag does not exist the tag would be "NONE", shouldn't we stop the release if not gittag is defined?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the gittag is NONE is_publish_build will be false in the next step which will skip the release
image

clementetb

This comment was marked as duplicate.

@nhachicha nhachicha changed the title Testing release process Automate release process to Maven Central and Gradle Plugin Portal Mar 8, 2024
@nhachicha nhachicha merged commit de600da into main Mar 8, 2024
4 of 14 checks passed
@nhachicha nhachicha deleted the nh/GHA/release branch March 8, 2024 10:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants