Fix race condition in ProgressListenerTest #1633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
January 18, 2024 11:10
2 tasks
added 7 commits
January 22, 2024 19:55
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
Added logic to App bootstrap so all schemas are uploaded and sync bootstrap is complete before starting any tests. (+8 squashed commits) Squashed commits: [ec71892] Add global flag for platform networking and disable all [f561da7] Disable platform networking [2629079] Ignore test [9e16ae3] Enable multiplexing [dd2ec4a] Increase log level [2c26134] Formatting [4cfac28] Add more debugging to tests [f504318] Remove debug output
cmelchior
force-pushed
the
cm/fix-progress-test
branch
from
7ed3e6d
to
b2beca0
Compare
cmelchior
pushed a commit
that referenced
this pull request
Jan 30, 2024
|
Replaced by #1645 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1628
This race condition was hit on GitHub Actions, and was hit when we called
Realm.close()before the async task could run. This resulted in an exception about a closed pointer whenflow.collect { }was subsequently called.