-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new publishCIPackages target in Gradle to make it easier to control which targets to build on a given platform #1607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic seems ok, but implementation feels a bit cumbersome. I think I would have gone for a HostSpecifics
-publication (#naming 🤪) and some conditional publishing that only published the host specific packages on publishHostSpecificPublicationTo<Repository>
. That feels more aligned with the publishing infrastructure ... and would be really cool for local development if you could just do publicHostSpecificsToMavenLocal
and install the artifacts needed on your platform.
But probably not worth redoing now 🤷
With this change, it is now possible to define which targets to build using. It does this by introducing a new target
publishCIPackages
, which can be configured using a number of new Gradle properties:With this it is possible to get fine-grained control over exactly what gets built on a CI runner.
This PR is mostly moving things out of #881, so we can keep the review more focused.