[CI] Sync tests with Device farm #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Guarding against empty logcat pull from Device farm
cmelchior
approved these changes
Jan 8, 2024
| @@ -0,0 +1,72 @@ | |||
| name: 'Run Android tests on Device Farm' | |||
There was a problem hiding this comment.
Unless I am missing it, the only difference between this action and run-android-device-farm-test seems to be the package name: io.realm.sync.testapp.test vs. io.realm.testapp.test. Isn't there a way we can combine them?
I guess app_auxiliary_files is also a difference, but couldn't we just make that optional?
There was a problem hiding this comment.
Updated with common action used for sync and non-sync device farm tests
…sync_test_device_farm
Co-authored-by: Christian Melchior <[email protected]>
cmelchior
approved these changes
Jan 10, 2024
|
Merging this to unblock merges coming from the other direction |
cmelchior
pushed a commit
that referenced
this pull request
Jan 10, 2024
This reverts commit c2e0810.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses BAAS CLI to run sync tests for Android (via Device Farm) JVM, macOS and iOS