Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Realm.asFlow() potentially missing an update when doing a write immediately after opening the Realm #1599

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

cmelchior
Copy link
Contributor

Closes #1582
Closes #1574

@cmelchior cmelchior marked this pull request as ready for review December 14, 2023 20:42
@cmelchior
Copy link
Contributor Author

Ready for review

Copy link
Contributor

@rorbech rorbech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🧐

@@ -90,6 +90,45 @@ class RealmNotificationsTests : FlowableTests {
}
}

@Test
fun registerTwoFlows() = runBlocking {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was covered in cancelAsFlow, but I guess it is nice with an explicit test.

@cmelchior cmelchior merged commit d558434 into main Dec 15, 2023
2 of 3 checks passed
@cmelchior cmelchior deleted the cm/bug-initial-realm-event branch December 15, 2023 08:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants