Propagate user-level exceptions during client reset #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmelchior
approved these changes
Dec 22, 2023
rorbech
reviewed
Dec 22, 2023
rorbech
reviewed
Dec 22, 2023
There was a problem hiding this comment.
I am not follow the updates to how the global refs on the
error_user_codeare managed. Might be that I have missed something, but will have to check it out to get the insights. Or do you have any magic one liner that can give the overview?
I see the connection now. I was just confused as I though it had something to do with the removed PopLocalFrames. But after settling that these were removed by mistake I get it.
But still think there is an erroneous asStableRef on Darwin.
packages/cinterop/src/nativeDarwin/kotlin/io/realm/kotlin/internal/interop/RealmInterop.kt
Show resolved
Hide resolved
packages/cinterop/src/nativeDarwin/kotlin/io/realm/kotlin/internal/interop/RealmInterop.kt
Show resolved
Hide resolved
packages/cinterop/src/nativeDarwin/kotlin/io/realm/kotlin/internal/interop/RealmInterop.kt
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-level exceptions were not propagated to the users via the exception channels. The exception message was printed on the stderr channel and swallowed.
This PR fixes this issue allowing the user-level exceptions to propagate all the way through the proper channels. Now it would be available as the
ClientResetFailedthrowable cause.Depends on realm/realm-core#7148
Closes #1580