Add support for multiplexing and SyncTimeoutOptions #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rorbech
approved these changes
Nov 21, 2023
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/AppConfiguration.kt
Outdated
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/AppConfiguration.kt
Outdated
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/sync/SyncTimeoutOptions.kt
Outdated
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/sync/SyncTimeoutOptions.kt
Outdated
Show resolved
Hide resolved
...library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/sync/SyncTimeoutOptionsBuilder.kt
Outdated
Show resolved
Hide resolved
clementetb
reviewed
Nov 21, 2023
...library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/sync/SyncTimeoutOptionsBuilder.kt
Outdated
Show resolved
Hide resolved
nhachicha
requested changes
Nov 22, 2023
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/AppConfiguration.kt
Outdated
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/AppConfiguration.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Nabil Hachicha <[email protected]> Co-authored-by: Claus Rørbech <[email protected]> Co-authored-by: clementetb <[email protected]>
…ngodb/AppConfiguration.kt Co-authored-by: Claus Rørbech <[email protected]>
rorbech
changed the title
rorbech
approved these changes
Nov 28, 2023
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/AppConfiguration.kt
Outdated
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/sync/SyncTimeoutOptions.kt
Show resolved
Hide resolved
...library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/sync/SyncTimeoutOptionsBuilder.kt
Show resolved
Hide resolved
...test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/AppConfigurationTests.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #971
This should also put some hooks in place to make it easier to control initial sync performance as reported by the internal help ticket here https://jira.mongodb.org/browse/HELP-47093
Terminology and API docs have been copied from the Swift implementation: realm/realm-swift#8282
This PR will not enable multiplexing by default, this is left for a future release.
It hasn't been possible to write an integration test for this, but I verified the changes manually by inspecting the logs, which at least shows the PING changes:
And the debugger shows the values being set