Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing compiler crash when using 1.9.20 with Sync #1568

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

nhachicha
Copy link
Collaborator

Fixes #1566 toIrConst moved under common IrUtils in Kotlin 1.9.20 JetBrains/kotlin@ca8db7d

bundleId is a string so we can work around using toIrConstOrNull by using IrConstImpl.string

@nhachicha nhachicha self-assigned this Nov 13, 2023
Copy link
Contributor

@rorbech rorbech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM ... if CI is happy.

@rorbech
Copy link
Contributor

rorbech commented Nov 13, 2023

Hmm, forgot: We should bump https://github.com/realm/realm-kotlin/blob/main/buildSrc/src/main/kotlin/Config.kt#L131 to 1.9.20 and maybe also create an issue to create a sync-enabled test that uses latestKotlin so that we catch this on CI later on.

@cmelchior cmelchior merged commit 9d23735 into main Nov 27, 2023
2 checks passed
@cmelchior cmelchior deleted the nh/fix_compiler_toIrConstOrNull branch November 27, 2023 14:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sync] Internal error in file lowering: java.lang.NoSuchMethodError with Kotlin 1.9.20
3 participants