Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump core to version 13.23.1 #1545

Merged
merged 13 commits into from
Oct 19, 2023
Merged

Bump core to version 13.23.1 #1545

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5098395
Bump core to version 13.23.0
clementetb Oct 12, 2023
c0180c5
Remove workaround for realm file name
clementetb Oct 16, 2023
5234ba4
Update metadata schema version
clementetb Oct 16, 2023
ed8e5f9
Update name test cases
clementetb Oct 16, 2023
8da19a0
Update test cases
clementetb Oct 17, 2023
dc02b10
Bump core commit
clementetb Oct 18, 2023
8fc52a9
Fix client reset flaky test
clementetb Oct 18, 2023
ee4fe03
bump baas
clementetb Oct 18, 2023
bacf3b0
Fix test case
clementetb Oct 18, 2023
6d087db
Close open channels
clementetb Oct 18, 2023
25fc7c6
Add changelog downgrade warning
clementetb Oct 19, 2023
9a14ae7
Update packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mo…
clementetb Oct 19, 2023
4f5ed7e
Update CHANGELOG.md
clementetb Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ GET requests. (Issue [#1517](https://github.com/realm/realm-kotlin/pull/1517))
* Minimum Android SDK: 16.

### Internal
* None.
* Updated to Realm Core 13.23.0, commit f8604b9fd3d2982008a1d3f5ff35e52ee9098d5b.


## 1.11.1 (2023-09-07)
Expand Down
1 change: 0 additions & 1 deletion packages/cinterop/src/commonMain/kotlin/io/realm/kotlin/internal/interop/RealmInterop.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,6 @@ expect object RealmInterop {
// User
fun realm_user_get_all_identities(user: RealmUserPointer): List<SyncUserIdentity>
fun realm_user_get_identity(user: RealmUserPointer): String
fun realm_user_get_auth_provider(user: RealmUserPointer): AuthProvider
fun realm_user_get_access_token(user: RealmUserPointer): String
fun realm_user_get_refresh_token(user: RealmUserPointer): String
fun realm_user_get_device_id(user: RealmUserPointer): String
Expand Down
4 changes: 0 additions & 4 deletions packages/cinterop/src/jvm/kotlin/io/realm/kotlin/internal/interop/RealmInterop.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,10 +1114,6 @@ actual object RealmInterop {
return realmc.realm_user_get_identity(user.cptr())
}

actual fun realm_user_get_auth_provider(user: RealmUserPointer): AuthProvider {
return AuthProvider.of(realmc.realm_user_get_auth_provider(user.cptr()))
}

actual fun realm_user_get_access_token(user: RealmUserPointer): String {
return realmc.realm_user_get_access_token(user.cptr())
}
Expand Down
4 changes: 0 additions & 4 deletions packages/cinterop/src/nativeDarwin/kotlin/io/realm/kotlin/internal/interop/RealmInterop.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2287,10 +2287,6 @@ actual object RealmInterop {
return realm_wrapper.realm_user_get_identity(user.cptr()).safeKString("identity")
}

actual fun realm_user_get_auth_provider(user: RealmUserPointer): AuthProvider {
return AuthProvider.of(realm_wrapper.realm_user_get_auth_provider(user.cptr()))
}

actual fun realm_user_is_logged_in(user: RealmUserPointer): Boolean {
return realm_wrapper.realm_user_is_logged_in(user.cptr())
}
Expand Down
2 changes: 1 addition & 1 deletion packages/external/core
Open in desktop
Submodule core updated 193 files
1 change: 1 addition & 0 deletions packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/User.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public interface User {
* Returns the provider type used to log the user in.
* If a user logs out, the authentication provider last used to log the user in will still be returned.
*/
@Deprecated("Property not stable, users might have multiple providers.", ReplaceWith("identities"))
clementetb marked this conversation as resolved.
Show resolved Hide resolved
public val provider: AuthenticationProvider

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/internal/UserImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public class UserImpl(
override val loggedIn: Boolean
get() = RealmInterop.realm_user_is_logged_in(nativePointer)
override val provider: AuthenticationProvider
get() = AuthenticationProviderImpl.fromId(RealmInterop.realm_user_get_auth_provider(nativePointer))
get() = identities.first().provider
override val accessToken: String
get() = RealmInterop.realm_user_get_access_token(nativePointer)
override val refreshToken: String
Expand Down
8 changes: 1 addition & 7 deletions ...ages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/sync/SyncConfiguration.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import io.realm.kotlin.TypedRealm
import io.realm.kotlin.internal.ConfigurationImpl
import io.realm.kotlin.internal.ContextLogger
import io.realm.kotlin.internal.ObjectIdImpl
import io.realm.kotlin.internal.REALM_FILE_EXTENSION
import io.realm.kotlin.internal.interop.RealmInterop
import io.realm.kotlin.internal.interop.SchemaMode
import io.realm.kotlin.internal.platform.PATH_SEPARATOR
Expand Down Expand Up @@ -606,12 +605,7 @@ public interface SyncConfiguration : Configuration {
)
}

// Remove .realm extension if user has overridden filename manually
return if (name != null) {
absolutePath.removeSuffix(REALM_FILE_EXTENSION)
} else {
absolutePath
}
return absolutePath
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/AppTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ class AppTests {
Realm.open(syncConfig).close()

// Create a configuration pointing to the metadata Realm for that app
val lastSetSchemaVersion = 6L
val lastSetSchemaVersion = 7L
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I don't really know the full consequence of this, but from this comment it seems that we should at least warn about not being able to downgrade 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are opening the metadata directly instead of opening a higher schema version with an app to trigger a schema downgrade.

I am going to create a ticket to validate what is the expected behavior when downgrading an App metadata schema.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1549

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh sorry, forgot the link to the comment I was referring to: #1528 (comment)

val metadataDir = "${app.configuration.syncRootDirectory}/mongodb-realm/${app.configuration.appId}/server-utility/metadata/"
val config = RealmConfiguration
.Builder(setOf())
Expand Down
4 changes: 2 additions & 2 deletions ...es/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/SyncConfigTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,8 +1261,8 @@ class SyncConfigTests {
val config: SyncConfiguration = SyncConfiguration.Builder(user, partitionValue, setOf())
.name(fileName)
.build()
val suffix = pathOf("", "mongodb-realm", user.app.configuration.appId, user.id, fileName)
val suffix = pathOf("", "mongodb-realm", user.app.configuration.appId, user.id, "$fileName.realm")
assertTrue(config.path.endsWith(suffix), "${config.path} failed.")
assertEquals(fileName, config.name, "${config.name} failed.")
assertEquals("$fileName.realm", config.name, "${config.name} failed.")
}
}