Tests GC realm pointer release #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmelchior
approved these changes
Oct 11, 2023
packages/cinterop/src/nativeDarwinTest/kotlin/io/realm/kotlin/test/CinteropTest.kt
Outdated
Show resolved
Hide resolved
packages/cinterop/src/nativeDarwinTest/kotlin/io/realm/kotlin/test/CinteropTest.kt
Outdated
Show resolved
Hide resolved
rorbech
reviewed
Oct 13, 2023
| @@ -57,63 +55,6 @@ class MemoryTests { | |||
| deleteTempDir(tmpDir) | |||
| } | |||
|
|
|||
| // TODO Only run on macOS, filter using https://developer.apple.com/documentation/foundation/nsprocessinfo/3608556-iosapponmac when upgrading to XCode 12 | |||
There was a problem hiding this comment.
Why are we removing this test? The other test is only verifying that garbage collecting of our native pointer wrapper is actually causing a realm_release but that is just a subset of ensuring that we actually release all resource and close the realm when not referencing a realm anymore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test case to catch whether we are releasing realm pointers.