Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on KAPT #1534

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Remove dependency on KAPT #1534

merged 1 commit into from
Oct 4, 2023

Conversation

cmelchior
Copy link
Contributor

Closes #1513

Fixes the error in #1513, but it will just move the error to another. Most likely

> 'compileDebugJavaWithJavac' task (current target is 1.8) and 'compileDebugKotlinAndroid' task (current target is 17) jvm target compatibility should be set to the same Java version.
  Consider using JVM toolchain: https://kotl.in/gradle/jvm/toolchain

Copy link
Contributor

@clementetb clementetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Did you try setting up the JVM toolchain to see if it fixes issue too? It might prevent the JVM setup to fail.

https://kotl.in/gradle/jvm/toolchain

@cmelchior
Copy link
Contributor Author

Yes, setting the toolchain in the Kotlin block fixes the issue, but it is not something we can do for people. They have to decide which java version to support. We should probably have it added to our documentation though.

@cmelchior cmelchior merged commit 0cc98c0 into main Oct 4, 2023
5 checks passed
@cmelchior cmelchior deleted the cm/remove-kapt branch October 4, 2023 09:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot compile with Kotlin 1.9.10
2 participants