Add geo types sync integration tests. #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmelchior
reviewed
Oct 3, 2023
| @@ -49,7 +49,7 @@ public class UserImpl( | |||
| override val loggedIn: Boolean | |||
| get() = RealmInterop.realm_user_is_logged_in(nativePointer) | |||
| override val provider: AuthenticationProvider | |||
| get() = AuthenticationProviderImpl.fromId(RealmInterop.realm_user_get_auth_provider(nativePointer)) | |||
| get() = identities.first().provider | |||
There was a problem hiding this comment.
Talking to JS, we should deprecate this method as it doesn't really make sense anymore and instead point people towards user.identities.
| import kotlin.test.assertFails | ||
| import kotlin.time.Duration.Companion.seconds | ||
|
|
||
| private val GEO_SCHEMA = setOf(SyncRestaurant::class, Location::class) |
There was a problem hiding this comment.
We cannot use this anymore. All schemas need to be the same after the server introduced the new developer mode. I have a branch you can work from.
cmelchior
reviewed
Oct 3, 2023
packages/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/GeoSpatialTests.kt
Outdated
Show resolved
Hide resolved
|
|
||
| Realm.open(config).use { | ||
| it.writeBlocking { | ||
| assertFails { |
There was a problem hiding this comment.
I don't think the write will fail as long as the class is in the schema, instead you will probably see a compensating write?
There was a problem hiding this comment.
It fails with RLM_ERR_NO_SUBSCRIPTION_FOR_WRITE. It is core preemptively catching the error.
packages/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/GeoSpatialTests.kt
Outdated
Show resolved
Hide resolved
packages/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/GeoSpatialTests.kt
Outdated
Show resolved
Hide resolved
packages/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/GeoSpatialTests.kt
Outdated
Show resolved
Hide resolved
packages/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/GeoSpatialTests.kt
Outdated
Show resolved
Hide resolved
clementetb
force-pushed
the
ct/geo-sync-tests
branch
from
51e0b87
to
05eca72
Compare
# Conflicts: # CHANGELOG.md # dependencies.list
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to validate we can define sync subscriptions using geo queries.