Fix SyncConfig tests that would break on Windows #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rorbech
approved these changes
Sep 14, 2023
| @@ -29,6 +29,7 @@ import io.realm.kotlin.entities.sync.flx.FlexChildObject | |||
| import io.realm.kotlin.entities.sync.flx.FlexEmbeddedObject | |||
| import io.realm.kotlin.entities.sync.flx.FlexParentObject | |||
| import io.realm.kotlin.ext.query | |||
| import io.realm.kotlin.internal.platform.PATH_SEPARATOR | |||
There was a problem hiding this comment.
Hmm. Not for this PR, but unfortunate #naming ... File.pathSeparator is usually for separating multiple path entries and not the directory separator 🙃
packages/test-sync/src/commonTest/kotlin/io/realm/kotlin/test/mongodb/common/SyncConfigTests.kt
Outdated
Show resolved
Hide resolved
Add a new pathOf method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests in
SyncConfigTestsassumed some things about path separators that it shouldn't