-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metric overhaul #1504
Merged
Merged
Metric overhaul #1504
Changes from 23 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
64d23c6
Metric overhaul
rorbech 902e8f7
Support gradle configuration caching
rorbech 8f869f4
Apply suggestions from code review
rorbech 544a3c4
Updates according to review comments
rorbech 50a79be
Fix json formatting
rorbech da915cc
Merge remote-tracking branch 'origin/cr/metrics-overhaul' into cr/met…
rorbech 4b7ee93
Merge branch 'main' into cr/metrics-overhaul
rorbech 410bbd4
Read core version through platform agnostic APIs
rorbech 2c861cf
Update documentation of dumping options
rorbech 73501df
Fix windows build.
cmelchior 7dcf74c
Enable collection of metrics in CI builds
rorbech ddad510
Update builder id string when failing
rorbech 27da2a0
Fix cocoapods reference in collected metrics
rorbech 0cb3003
Bump minimum supported Gradle version
rorbech cb866a6
Change info message prefix
rorbech 5351adb
Gradle version differentiation and error handling
rorbech 18aaa89
Add gradle version test projects
rorbech cb61636
Clean up gradle compatibility tests
rorbech 6b51f79
Run Gradle8 tests with JDK 17
rorbech 471a9bb
Fix gradle8 build issue
rorbech cd59445
Fix jenkins environment for gradle 8 build
rorbech 34f2882
Merge branch 'main' into cr/metrics-overhaul
rorbech 01e10a1
Upgrade minimum supported Kotlin version
rorbech 9f9a301
Add gradle integration project with current version
rorbech d4b65d6
Revert minimum supported Gradle version
rorbech aff72ae
Revert project settings
rorbech a22da77
Merge branch 'main' into cr/metrics-overhaul
rorbech a3598de
Bump Kotlin version in integration tests to fit new minimum version
rorbech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
5 changes: 5 additions & 0 deletions
5
integration-tests/gradle/gradle6-test/gradle/wrapper/gradle-wrapper.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-6.8.3-all.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/* | ||
* Copyright 2022 Realm Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
* or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
// Explicitly adding the plugin to the classpath as it makes it easier to control the version | ||
// centrally (don't need version in the 'plugins' block). Further, snapshots are not published with | ||
// marker interface so would need to be added to the classpath manually anyway. | ||
buildscript { | ||
extra["realmVersion"] = file("${rootProject.rootDir.absolutePath}/../../../buildSrc/src/main/kotlin/Config.kt") | ||
.readLines() | ||
.first { it.contains("const val version") } | ||
.let { | ||
it.substringAfter("\"").substringBefore("\"") | ||
} | ||
|
||
repositories { | ||
maven(url = "file://${rootProject.rootDir.absolutePath}/../../../packages/build/m2-buildrepo") | ||
gradlePluginPortal() | ||
google() | ||
mavenCentral() | ||
} | ||
dependencies { | ||
classpath("com.android.tools.build:gradle:7.0.0") | ||
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20") | ||
classpath("io.realm.kotlin:gradle-plugin:${rootProject.extra["realmVersion"]}") | ||
} | ||
} | ||
group = "io.realm.test" | ||
version = rootProject.extra["realmVersion"] | ||
|
||
// Attempt to make an easy entry point for verifying all modules. Maybe we could do a better split | ||
// when migrating to GHA. | ||
tasks.register("integrationTest") { | ||
dependsOn(":single-platform:connectedDebugAndroidTest") | ||
dependsOn(":multi-platform:cleanAllTests") | ||
dependsOn(":multi-platform:jvmTest") | ||
dependsOn(":multi-platform:nativeTest") | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# | ||
# Copyright 2022 Realm Inc. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
# or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
kotlin.code.style=official | ||
|
||
org.gradle.jvmargs=-Xmx4096M | ||
|
||
android.useAndroidX=true | ||
android.enableJetifier=true | ||
|
||
kotlin.mpp.stability.nowarn=true | ||
|
||
# Enable new memory model as default | ||
kotlin.native.binary.memoryModel=experimental | ||
kotlin.native.binary.freezing=disabled | ||
|
||
org.gradle.configuration-cache=true |
Binary file added
BIN
+59.3 KB
integration-tests/gradle/gradle71-test/gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
2 changes: 1 addition & 1 deletion
2
.../gradle/wrapper/gradle-wrapper.properties → .../gradle/wrapper/gradle-wrapper.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-all.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.1-all.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is because you want to decouple the tests completely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It we use
buildSrc
to gain access toConfig.kt
it is problematic to use Kotlin and AGP versions that are different from the ones inConfig.kt
becausebuildSrc
applies a number of plugins and that will fix the versions.