-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialization of RealmAny with collections #1494
Merged
rorbech
merged 15 commits into
cr/collections-in-mixed
from
cr/collection-in-mixed-serialization
Sep 5, 2023
Merged
Serialization of RealmAny with collections #1494
rorbech
merged 15 commits into
cr/collections-in-mixed
from
cr/collection-in-mixed-serialization
Sep 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # packages/cinterop/src/commonMain/kotlin/io/realm/kotlin/internal/interop/ErrorCode.kt # packages/cinterop/src/jvm/kotlin/io/realm/kotlin/internal/interop/ErrorCode.kt # packages/cinterop/src/nativeDarwin/kotlin/io/realm/kotlin/internal/interop/ErrorCode.kt # packages/external/core
# Conflicts: # packages/external/core
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a suggested workaround for support of serialization of
RealmAny
s with nested collections.It seems that statically annotated serializers cannot be mutually recursive, so
RealmListKSerializer
, etc. cannot be used to serializeRealmList<RealmAny?>
from inside theRealmAny
serializer. This PR is a suggested workaround for this until we get to the root of the issue, but requires users to manual add the contextual serializers as shown in the tests in https://github.com/realm/realm-kotlin/compare/cr/collections-in-mixed...cr/collection-in-mixed-serialization?expand=1#diff-64803515612f60c2bc368eac00a24dab29eaee3b05952461ffb092790cc55c76R92.