Rework internal sync error handling #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 23, 2023 11:36
cmelchior
requested review from
rorbech,
nhachicha and
clementetb
and removed request for
clementetb
rorbech
approved these changes
Aug 25, 2023
packages/cinterop/src/commonMain/kotlin/io/realm/kotlin/internal/interop/CoreError.kt
Outdated
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/internal/RealmSyncUtils.kt
Outdated
Show resolved
Hide resolved
packages/cinterop/src/commonMain/kotlin/io/realm/kotlin/internal/interop/CoreError.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the old SyncClient, SyncProtocol, and SyncSession errors are gone and have been rolled up into the general RealmError struct. This PR reworks our error handling to accommodate this.
Since we are hiding the real errors behind our exception hierarchy, there should be no visible change to end users. The only exception is the exception message which might now contain different categories and codes, but the behavior should be the same.
Some notable changes:
CoreErrorclass has been added that mirrors the C struct realm_error_t.CategoryFlagshave been expanded and are now also used for Sync Errors where it previously was only used for local exceptions.