Add custom implementations for toString, equals and hashCode #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rorbech
approved these changes
Aug 14, 2023
| @@ -58,48 +50,6 @@ class RealmModelSyntheticCompanionExtension : SyntheticResolveExtension { | |||
| } | |||
| } | |||
|
|
|||
| override fun addSyntheticSupertypes( | |||
There was a problem hiding this comment.
I am not sure that these are safe to delete. I think it was added because the default implementation is no longer part of the interface (aka related to the changed jvm-default mode) in https://github.com/realm/realm-kotlin/pull/1163/files. But maybe ok now that we compile against 1.8+ which we also run against 🤔 ... I guess it should be safe.
packages/library-base/src/commonMain/kotlin/io/realm/kotlin/internal/RealmObjectHelper.kt
Outdated
Show resolved
Hide resolved
| @Suppress("unused", "MagicNumber") // Called from generated code | ||
| // Inlining this functions somehow break the IntelliJ debugger, unclear why? | ||
| internal fun realmHashCode(obj: BaseRealmObject): Int { | ||
| // This code assumes no race conditions |
There was a problem hiding this comment.
Should we put some notes about the side effects of this: Not thread safe on live objects or something like that.
There was a problem hiding this comment.
We probably should, but not sure where it would make sense?
packages/library-base/src/commonMain/kotlin/io/realm/kotlin/internal/RealmObjectUtil.kt
Outdated
Show resolved
Hide resolved
packages/plugin-compiler/src/main/kotlin/io/realm/kotlin/compiler/Registrar.kt
Show resolved
Hide resolved
...lugin-compiler/src/main/kotlin/io/realm/kotlin/compiler/RealmModelDefaultMethodGeneration.kt
Show resolved
Hide resolved
packages/test-base/src/commonTest/kotlin/io/realm/kotlin/test/common/RealmListTests.kt
Show resolved
Hide resolved
packages/test-base/src/commonTest/kotlin/io/realm/kotlin/test/common/RealmObjectTests.kt
Show resolved
Hide resolved
...lugin-compiler/src/main/kotlin/io/realm/kotlin/compiler/RealmModelDefaultMethodGeneration.kt
Show resolved
Hide resolved
rorbech
reviewed
Aug 14, 2023
packages/library-base/src/commonMain/kotlin/io/realm/kotlin/internal/RealmObjectHelper.kt
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1097
This PR adds custom
toString,equals, andhashCodeimplementations to Realm Object subclasses. If these methods already exist, nothing will be generated.TODO