Remove all deprecated APIs from the compiler plugin. #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a bit closer to K2 support.
cmelchior
changed the title
|
Using Kotlin 1.8.0, Gradle 7.3.3, and AGP 7.2.0, I hit a few cases not covered by our minimal sample project. I had to backport a single helper method and work around another case where a helper method was no longer available. But with these changes all tests run locally. |
rorbech
approved these changes
Aug 10, 2023
packages/plugin-compiler/src/main/kotlin/io/realm/kotlin/compiler/Identifiers.kt
Outdated
Show resolved
Hide resolved
packages/plugin-compiler/src/main/kotlin/io/realm/kotlin/compiler/Identifiers.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the compiler plugin, so it no longer uses deprecated APIs. This should move us closer to K2 support, but I'm keeping support out of this for now.
@FirIncompatiblePluginAPIhas been reworked.FqNamestoClassIdandCallableId.Regarding testing. Our library is built and tested with Kotlin 1.8.21. We do have a minimal sample project being built with 1.8.20, but I'll see if all tests run on 1.8.20 as well, just to be sure we are not breaking backwards compatibility.