Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for persisted name links in lists #1462

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

rorbech
Copy link
Contributor

@rorbech rorbech commented Jul 25, 2023

No description provided.

@clementetb
Copy link
Contributor

It works well for changing the name of an entity but only when this entity is not part of a RealmList.

I interpreted this like:

class Parent {
    var children: RealmList<Child> = realmListOf()
}

@PersistedName("RenamedChild")
class Child {
    var name: String = ""
}

@rorbech
Copy link
Contributor Author

rorbech commented Jul 25, 2023

But that is also part of the test. In my test I am just also renaming the children property, but should still show that the parent can have a list of Children even though Child is renamed.

@clementetb
Copy link
Contributor

Arg, I only read the incoming changes 🤦🏻‍♂️

Copy link
Contributor

@cmelchior cmelchior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor comment about the test and CI needs to be green 🚀

@rorbech rorbech merged commit 311a6ae into releases Aug 1, 2023
1 of 2 checks passed
@rorbech rorbech deleted the cr/persisted-name-links-in-lists branch August 1, 2023 08:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants