Fix realm-react progress tests #6833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
gagik
commented
Aug 12, 2024
| @@ -47,9 +47,14 @@ type Indirects = { | |||
| */ | |||
| export const indirect = {} as Indirects; | |||
|
|
|||
| const IGNORED_PROPS = new Set([ | |||
| // See https://github.com/realm/realm-js/issues/6522 | |||
| "$$typeof", | |||
There was a problem hiding this comment.
This was causing me issues before and existed pre-refactor; was the new refactor meant to resolve this? @kraenhansen
There was a problem hiding this comment.
I didn't think of that issue 👍 good catch. I believe it'll be good to have a set of ignored props.
kraenhansen
approved these changes
Aug 12, 2024
kraenhansen
added
no-jira-ticket
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Minor fixes from previous PR feedback
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary@realm/devdocsif documentation changes are needed