Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RJS-2187: Add progress information to RealmProvider fallback. #6801
RJS-2187: Add progress information to RealmProvider fallback. #6801
Changes from all commits
865cf14
867925a
3ec2d0f
437725f
a018089
a98a1cd
1ad08db
f0d8586
5c82baa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(How) is this mock restored? Perhaps this side-effect could be moved into the test where you could also call jest.restoreAllMocks() to avoid this state bleeding into other tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been running the cleaning but I agree it's not intuitive that this side effect exists. Maybe even extending this jest with like
jest.mockRealmOpen()
could be the most consistent with rest of jest mock API to have these mock helpers (and then intuitivelyjest.restoreAllMocks()
cleans them).Alternatively we wrap them in a hook which includes a clean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like extending jest isn't the norm as it is with extending
expect
so I guess we either can define a hook with cleanup built in (although then if we have multiple mocks we'd be running the cleanup too much) or use the function as is and just make sure to run therestoreAllMocks