Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Date and ObjectId arguments in MDB client #6029

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

takameyer
Copy link
Contributor

@takameyer takameyer commented Aug 2, 2023

What, How & Why?

  • Date and ObjectId were being transformed into an empty object on the way to the MDB client
  • Modified the cleanArguments utility to not overwrite these objects with an empty one

This closes #6030

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated

* Date and ObjectId were being transformed into an empty object on the way to the MDB client
* Modified the cleanArguments utility to not overwite these objects with an empty one
@takameyer takameyer merged commit b9de4e7 into main Aug 3, 2023
17 checks passed
@takameyer takameyer deleted the andrew/fix-mdb-client branch August 3, 2023 07:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MongoDB client transforming Date and ObjectId into empty objects
1 participant